Skip to content

Move apps out of Kernel with new kernel API implementation - #71

Merged
Rhylanscript merged 33 commits into
mainfrom
feat/move-apps-out-of-kernel
Oct 20, 2026
Merged

Rhylanscript merged 33 commits into
mainfrom
feat/move-apps-out-of-kernel

Conversation

@Rhylanscript

Copy link
Copy Markdown
Owner

Added

  • VAPP (VIGIL APP) file format for VIGIL apps
  • Fixed memory slots for apps
  • Kernel loader that registers app files with the launcher
  • Hello as an example loadable app

Changed

  • Moved Calculator, Files, and Notepad out of the kernel (Terminal remains builtin)
  • Expose kernel functions to separately compiled apps using a versioned VIGIL API
  • Update launcher and shell to discover apps at startup and load apps on demand
  • Launcher now assigns files on open to Notepad
  • Updated build process to compile apps separately and install them onto the storage disk

Documentation

  • Updated README.md to reflect changes
  • Default QEMU runs to SDL display mode

Cleanup branch for merge to main

@Rhylanscript Rhylanscript left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot review:

Assessment

The overall direction is solid, and I don’t see a clear runtime blocker in the loader design itself. The bigger issue is that this PR currently has no automated validation on the head commit: GitHub reports 0 check runs for the PR head, so the new VAPP build/install path is effectively unverified.

One concrete code issue I would fix before merge:

  • In apps/launcher/launcher.c, copy_app() assigns dest->on_prompt_done twice:
    • dest->on_prompt_done = src->on_prompt_done;
    • dest->on_prompt_done = src->on_prompt_done;
  • This is harmless today because it’s a duplicate assignment, but it makes the app-registration copy logic brittle and easy to accidentally overwrite newly added callbacks later (for example on_open_file/future app hooks). It’s a small but real maintenance bug in the new dynamic app path.

I’d also call out:

  • The new app-loader flow is substantial and should have at least one smoke build or CI check before merge, since there are currently no checks configured for this PR head.
  • That said, I don’t see an obvious functional blocker in the app registration/loader flow itself beyond the copy routine issue above.

Comment thread apps/launcher/launcher.c Resolved

@Rhylanscript Rhylanscript left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is a thoughtful architectural refactor and I don’t see a major functional blocker in the loader design itself.

PR summary:

  • Moves Calculator, Files, and Notepad out of the kernel while keeping Terminal builtin.
  • Adds a versioned kernel API table (vigil_api_t) for separately compiled apps.
  • Introduces a VAPP file format and loader that scans apps/ on the storage disk and registers apps at startup.
  • Updates the launcher/shell to discover apps and load them on demand.
  • Adds Hello as a sample loadable app and updates the build/install flow to package apps onto dist/storage.img.

Core changes:

  • App registration is now dynamic instead of hardcoded in the kernel build.
  • The kernel exposes a stable function table to apps so they can call graphics/filesystem services without linking against kernel internals.
  • The build now compiles apps separately, emits VAPP files, and installs them onto the storage disk.

Merge readiness:

  • Risk: Low-to-medium.
  • No obvious runtime blocker in the loader flow, but the new app-loading path is substantial and currently has no visible head-commit validation in the PR checks, so I’d treat this as “needs a green smoke build” before merge.

I’d also keep this as a merge prerequisite:

  • Confirm the new app build/install path passes CI or at least a smoke build on the PR head before merging.
  • The rest of the diff looks coherent and consistent with the PR’s intent.

@Rhylanscript
Rhylanscript merged commit 566fd75 into main Oct 20, 2026
1 check passed
@Rhylanscript
Rhylanscript deleted the feat/move-apps-out-of-kernel branch October 20, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant